Recent Code Changes - Comments remain "new" in pagination

Just pushed through an update to this site attempting to fix the new comments issue regarding to pagination (see here and here). Basically the problems are:

  1. When there are new comments spanning multiple pages of a deal/forum topic, once you hit the first page and then go to the second page, new comments are no longer marked as "new".
  2. Sometimes the "new comments" link goes to page 1 when it should have gone to subsequent page.
  3. Subscription link does not go to the correct page where the comment is.

They should hopefully be fixed now with page number properly calculated. And for (1) above, when you go between pages of the same deal/forum topic, new comments will remain marked as "new". The marker will only expire if:

  1. 5 minutes after you last visit that deal/forum topic, or
  2. You explicitly clicked on "mark all comments read" link (just above the first comment)

As usual, there will be bugs :) So test it out to see how it works.

Comments

  • crickets lol! Nice work Scotty.

Login or Join to leave a comment